ki.stfu accepted this revision. ki.stfu added a comment. This revision is now accepted and ready to land.
lgtm ================ Comment at: tools/lldb-mi/MICmdBase.cpp:102 @@ -99,2 +101,3 @@ m_setCmdArgs.Add(new CMICmdArgValOptionLong(m_constStrArgFrame, m_FrameArgMandatory, true, CMICmdArgValListBase::eArgValType_Number, 1)); + m_setCmdArgs.Add(new CMICmdArgValConsume(m_constStrArgConsume, false)); } ---------------- Well, I thought it's mandatory argument according to its spec: https://sourceware.org/gdb/onlinedocs/gdb/GDB_002fMI-Data-Manipulation.html ``` -data-disassemble [ -s start-addr -e end-addr ] | [ -f filename -l linenum [ -n lines ] ] -- mode ``` But I think we can follow to the GDB syntax. ================ Comment at: tools/lldb-mi/MICmdCmdData.cpp:280 @@ -279,3 +278,2 @@ new CMICmdArgValOptionShort(m_constStrArgAddrEnd, true, true, CMICmdArgValListBase::eArgValType_StringQuotedNumber, 1)); - m_setCmdArgs.Add(new CMICmdArgValConsume(m_constStrArgConsume, true)); m_setCmdArgs.Add(new CMICmdArgValNumber(m_constStrArgMode, true, true)); ---------------- ok, thanks. http://reviews.llvm.org/D14197 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits