jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

The part of this fix which is using info in the SymbolContext to make the 
language detection more accurate is fine.

We have to do something better about how we detect the language from a mangled 
name.  The target knows some that it should be able to contribute, but there's 
no clear way to do that now.  But you aren't making that any worse (except the 
one inline comment about cstring_is_mangled above, which will need to get 
fixed) so I don't think you are obligated to solve that problem now.


Repository:
  rL LLVM

http://reviews.llvm.org/D15326



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to