This patch is not acceptable as is. It enshrines an incorrect usage of the function cstring_is_mangled which we shouldn’t do. As I said in the previous comment, it’s okay to come up with a short term fix, and check the mangled flavor against Itanium and MSVC. So it shouldn’t be hard to replace the errant usage. Do that and its fine to go in.
Jim > On Dec 10, 2015, at 4:14 PM, Dawn Perchik <dawn+l...@burble.org> wrote: > > dawn added a comment. > > ping? > > > Repository: > rL LLVM > > http://reviews.llvm.org/D15326 > > >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
