================
@@ -234,9 +234,9 @@ class NativeRegisterContextLinux_arm64
 
   size_t GetFPMRBufferSize() { return sizeof(m_fpmr_reg); }
 
-  llvm::Error ReadHardwareDebugInfo() override;
+  Status ReadHardwareDebugInfo() override;
----------------
wangleiat wrote:

Because I noticed that the function calling it returns a `Status` (`virtual 
Status ClearAllHardwareWatchpoints()` in file 
lldb/include/lldb/Host/common/NativeRegisterContext.h), and other 
architectures, such as ARM (not AArch64) and PPC, also return a Status.
Should consistency be maintained here? If `llvm::Error` is required, I will 
revert it. I also made a mistake—the definition in this file 
`NativeRegisterContextFreeBSD_arm64.h` hasn't been updated yet. I apologize for 
my carelessness.

https://github.com/llvm/llvm-project/pull/118043
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to