wangleiat wrote: > This passed all tests. Some remaining cosmetic issues but otherwise looks > good. > > We could go more into the style issues here but > > 1. This code was like that before, you just moved it, so it's not actually a > regression. > 2. I don't want to get into refactoring and break tests again. If we want to > do that we can do it in small pieces later. > > Going to look again at the follow up PR as well.
Do you mean submitting the subsequent changes in a new PR? Since the `llvm::Error -> Status` modification is incomplete, it will cause a compilation error in `NativeRegisterContextFreeBSD_arm64.cpp`. Can I continue making modifications in this PR? https://github.com/llvm/llvm-project/pull/118043 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
