labath added inline comments.
================ Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:15 +#include "lldb/Target/MemoryRegionInfo.h" +#include "lldb/Utility/LLDBAssert.h" + ---------------- I think this is not needed anymore. ================ Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:252 + bool exists; + std::tie(iter, exists) = lowest_addr.emplace(std::make_pair( + module_name, std::make_pair(module.base_of_image, &module))); ---------------- The reason I suggested `emplace` instead of `insert` was that you could strip one level of `std::make_pair` here. I.e. ``` std::tie(iter, exists) = lowest_addr.emplace( module_name, std::make_pair(module.base_of_image, &module)); ``` https://reviews.llvm.org/D25569 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
