dvlahovski added inline comments.
================
Comment at: source/Plugins/Process/minidump/MinidumpTypes.cpp:222
+
+ if (header->size_of_header > sizeof(MinidumpMemoryInfoListHeader)) {
+ data = data.drop_front(header->size_of_header -
----------------
zturner wrote:
> I don't think you need the conditional here do you? Just `data =
> data.drop_front(sizeof_MinidumpMemoryInfoListHeader)`.
`header->size_of_header` is >= `sizeof(MinidumpMemoryInfoListHeader)` here. So,
yes, I can simplify it like this: `data =
data.drop_front(header->size_of_header - sizeof(MinidumpMemoryInfoListHeader));`
https://reviews.llvm.org/D25569
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
