Jlalond wrote:

> I see this is still a draft, but to avoid surprised, I want to say that I 
> think this should be two or three patches in the final form. One for the 
> PTRACE_SEIZE thingy, one for the "mechanism to prevent a process from 
> resuming" and maybe (depending on how involved it gets) one for refactoring 
> the /proc/status parser.

I'm okay with that, I'm still in the 'experiment and see what happens phase' 
when it comes to preventing continue.

How does this proposal sound:

* SEIZE + Parsing Proc Status
* GDB Server changes to prevent resumption
* Move the Proc Status (not stat) code to the HOST class

For #3, I think it's got some loose scope around if it should replace proc stat 
or be in addition to it. The biggest complexity here is we're adding 
information into qProcessInfo that isn't exclusively about the process but now 
about how we're interacting with the process. So I think tackling that as it's 
own step makes sense.

https://github.com/llvm/llvm-project/pull/137041
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to