labath wrote:

> Move the Proc Status (not stat) code to the HOST class

I'd put this first (in which case it wouldn't be called "move" but "extend" or 
"refactor"), for two reasons:
- it reduces the chance of ending up with two parsers
- I'm not very happy with the implementation you have here. I think using 
structured data is overkill and makes using it more complicated. Since this is 
an internal API, and we don't have to worry about stability, I think a struct 
with a bool field (or `optional<bool>` if you need to treat "not present" 
differently) would be better. (That's also more-or-less what the existing 
implementation does)

https://github.com/llvm/llvm-project/pull/137041
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to