JDevlieghere wrote: I took a look at the code and I think the approach looks good.
I wonder if there's an opportunity to make this slightly more generic to avoid (1) having to change the interface (i.e. keep returning an `llvm::Error`) and (2) defer the error response so there's no divergence between when we send a success and failure response. That would require doing the checking of the async condition (for async requests) as well as executing the callback (if we don't yet have an error) at the layer above it. I don't know how much that complicates things or if that's worth it (do we expect to use this anywhere else?) in which case feel free to ignore this. https://github.com/llvm/llvm-project/pull/140299 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
