https://github.com/JDevlieghere approved this pull request.

I think you can move this out of draft. I'm thoroughly convinced that my first 
stab at this is wrong. The code LGTM and I like that we don't have to launch 
everything with `stopOnEntry`. 

The only thing I don't like is that the configurationDone is now once again 
implicit. In a future PR, I'd love to move the tests to a model where we 
specify that explicitly after doing the breakpoints (and automatically catch 
cases where someone forgets, like your PR from earlier this week). I'm happy to 
sign myself up to do that work.

https://github.com/llvm/llvm-project/pull/140331
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to