danalbert added inline comments.

Comment at: cmake/platforms/Android.cmake:36
 # flags and definitions
 remove_definitions( -DANDROID -D__ANDROID__ )
You're removing it a line before just to add it back?

`__ANDROID__` is probably the one you want. That one is defined by Clang (and 
GCC if that matters) for any Android target, so no need to worry about dealing 
with it in cmake (or any other build system).

This isn't a concern right now, but if LLDB ever needed to become part of the 
Android platform build, `ANDROID` doesn't actually mean `ANDROID`; it gets set 
for host modules too :(


lldb-commits mailing list

Reply via email to