================ @@ -792,6 +792,12 @@ Status PluginManager::SaveCore(const lldb::ProcessSP &process_sp, } } + // report for one plugin if a name is specified. + if (error.Success() && !plugin_name.empty()) ---------------- DavidSpickett wrote:
It's so strange that this code (and the one before the return) reads like: if we did something good say that something went wrong I'm sure the logic works out somehow but it's not very clear. Addressing that here will make it even more confusing, but keep it in mind when dealing with this code. It seems tricky. https://github.com/llvm/llvm-project/pull/143126 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits