================
@@ -797,7 +797,8 @@ let Command = "process save_core" in {
     EnumArg<"SaveCoreStyle">, Desc<"Request a specific style "
     "of corefile to be saved.">;
   def process_save_core_plugin_name : Option<"plugin-name", "p">,
-    OptionalArg<"Plugin">, Desc<"Specify a plugin name to create the core 
file. "
+    Arg<"Plugin">, Completion<"ProcessSaveCorePlugin">,
----------------
Jlalond wrote:

I think almost all the tests specify a plugin, so this shouldn't affect us that 
much. I think we should keep the default behavior. Imagine if someone is using 
LLDB right now to capture Minidumps in an automated fashion and isn't 
specifying the plugin? We have accidentally created a user space contract and 
we shouldn't break that without communicating it.

https://github.com/llvm/llvm-project/pull/143126
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to