[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

[Jonas Devlieghere via lldb-commits]

================
@@ -1593,6 +1621,14 @@ DisassemblerLLVMC::DisassemblerLLVMC(const ArchSpec 
&arch,
     features_str += "+a,+m,";
   }
 
+  const char *additional_features =
+      arch.GetAdditionalDisassemblyFeatureStr().data();
+  // Prepend the additional_features if it's not already in the features_str to
+  // avoid duplicates.
+  if (additional_features) {
+    UpdateFeatureString(additional_features, features_str);
+  }
----------------
JDevlieghere wrote:

Why go through the hassle of going through a `const char*`? Just use the 
StringRef directly?

```suggestion
  llvm::StringRef additional_features =
      arch.GetAdditionalDisassemblyFeatureStr();
  // Prepend the additional_features if it's not already in the features_str to
  // avoid duplicates.
  if (additional_features) {
    UpdateFeatureString(additional_features, features_str);
  }
```

https://github.com/llvm/llvm-project/pull/147990
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits