[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. 
:warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- 
lldb/include/lldb/Utility/ArchSpec.h 
lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp 
lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.h 
lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp 
lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.h 
lldb/source/Utility/ArchSpec.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp 
b/lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp
index f034c43df..3b3e6341b 100644
--- a/lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp
+++ b/lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp
@@ -1620,8 +1620,7 @@ DisassemblerLLVMC::DisassemblerLLVMC(const ArchSpec &arch,
     features_str += "+a,+m,";
   }
 
-  llvm::StringRef additional_features =
-      arch.GetDisassemblyFeatures();
+  llvm::StringRef additional_features = arch.GetDisassemblyFeatures();
   // Prepend the additional_features if it's not already in the features_str to
   // avoid duplicates.
   if (!additional_features.empty()) {
diff --git a/lldb/source/Utility/ArchSpec.cpp b/lldb/source/Utility/ArchSpec.cpp
index e532caf0d..14e8e3f64 100644
--- a/lldb/source/Utility/ArchSpec.cpp
+++ b/lldb/source/Utility/ArchSpec.cpp
@@ -617,8 +617,7 @@ void ArchSpec::SetFlags(const std::string &elf_abi) {
   SetFlags(flag);
 }
 
-void ArchSpec::SetDisassemblyFeatures(
-    std::string additional_features) {
+void ArchSpec::SetDisassemblyFeatures(std::string additional_features) {
   if (m_disassembly_feature_str.find(additional_features) ==
       std::string::npos) {
     m_disassembly_feature_str += additional_features;

``````````

</details>


https://github.com/llvm/llvm-project/pull/147990
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits