https://github.com/delcypher approved this pull request.

Thanks for the explanation. A few suggestions:

* File an issue about the duplicate recognizer bugs and refer to it from the 
test case
* Improve the commit description to include your clearer explaination.

I'll approve now under the assumption you'll fix those. It's probably best you 
get approval from another LLDB maintainer though as this isn't my area of 
expertise.

https://github.com/llvm/llvm-project/pull/166157
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to