Michael137 wrote: > Thanks for the explanation. A few suggestions: > > * File an issue about the duplicate recognizer bugs and refer to it from the > test case > * Improve the commit description to include your clearer explaination. > > I'll approve now under the assumption you'll fix those. It's probably best > you get approval from another LLDB maintainer though as this isn't my area of > expertise.
Updated description and filed issue (https://github.com/llvm/llvm-project/issues/166341)! Thanks for the review https://github.com/llvm/llvm-project/pull/166157 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
