jimingham wrote:

I have three small quibbles and then this is good.  There was one place where 
you missed provider-name -> provider-id.  I think `target frame provider clear` 
should support multiple id's but if you don't want to do that in this patch, 
then define the argument repeat type correctly and you won't have check for 
more than one by hand.
And in the code that's unwinding provided frames, you should check for 
WasInterrupted and bail if it was set.

https://github.com/llvm/llvm-project/pull/161870
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to