================
@@ -82,6 +83,40 @@ bool StopInfo::HasTargetRunSinceMe() {
return false;
}
+void StopInfo::SkipOverTrapInstruction() {
+ Status error;
+ Log *log = GetLog(LLDBLog::Process);
+ // We don't expect to see byte sequences longer than four bytes long for
+ // any breakpoint instructions known to LLDB.
+ std::array<uint8_t, 4> bytes_at_pc = {0, 0, 0, 0};
+ auto reg_ctx_sp = GetThread()->GetRegisterContext();
+ auto process_sp = GetThread()->GetProcess();
+ addr_t pc = reg_ctx_sp->GetPC();
+ if (!process_sp->ReadMemory(pc, bytes_at_pc.data(), bytes_at_pc.size(),
+ error)) {
+ // If this fails, we simply don't handle the step-over-break logic and
+ // log the failure
----------------
DavidSpickett wrote:
full stop on end, but also, that you log is obvious from the call. I'd leave
that off.
Good instinct to add a comment that failure here is basically fine though. Hard
to tell sometimes what's a disaster and what isn't.
https://github.com/llvm/llvm-project/pull/174348
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
