================
@@ -218,6 +218,10 @@ class StopInfo : public
std::enable_shared_from_this<StopInfo> {
// to consult this later on.
virtual bool ShouldStop(Event *event_ptr) { return true; }
+ // Shared implementation for when a trap instruction leaves the CPU PC at
+ // the trap instruction instead of just after it.
+ void SkipOverTrapInstruction();
----------------
DavidSpickett wrote:
The comment is ok but I would expand to say:
* the purpose (to make sure the PC is after the trap)
* what the default implementation does (nothing? And that this is ok if the
architecture already puts the PC after)
* that architectures that disagree should override this
Though I see it's not virtual, so I might have a different take once I've read
the rest of this PR.
https://github.com/llvm/llvm-project/pull/174348
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
