DavidSpickett wrote: On testing: we discussed this on another PR and the situation is that because the coredumps are so large, they were generated by patching LLDB to make them smaller. The minidump format tests don't need that, I don't think. They are also only run when you've got specific libraries installed, which none of our usual CI machines do. So if the results drift, it's not going to impact anyone but FreeBSD users.
So I personally am ok with @mchoo7 doing these changes and then updating the tests later, and maybe we can figure out a better way for re-generating that doesn't involve patching lldb. I hope others agree with that. https://github.com/llvm/llvm-project/pull/178306 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
