DavidSpickett wrote: > No, this change is purely an NFC.
I don't think it is, because anyone calling Reset() on a HostThreadPosix is now also getting a pthread_detach. Which I thought would end up fixing the bug. If this were NFC, it would override the method and then immediately call the base class' method. Which is fine, but I need to see the follow up change before I can approve this. If I have misunderstood, it would help me if you could update the other PR to include this PR's commit, then as a second commit, the changes that fix the bug. Then I can see clearly what else you intend to do. https://github.com/llvm/llvm-project/pull/179470 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
