https://github.com/rchamala created https://github.com/llvm/llvm-project/pull/181492
## Summary - Move `#include "lldb/Core/PluginManager.h"` after `#include "ScriptInterpreterPythonInterfaces.h"` so Python's `pyconfig.h` defines `pid_t` before `PosixApi.h` gets included. This fixes the `C2371: 'pid_t': redefinition; different basic types` error on all Windows builders. Fixes CI failures from #181334 / #181488. ## Test plan - [ ] lldb-aarch64-windows build passes - [ ] lldb-x86_64-win build passes - [ ] lldb-remote-linux-win build passes >From 480a4a529c81d95fa77aa1ee553f7c5afe667c6c Mon Sep 17 00:00:00 2001 From: Rahul Reddy Chamala <[email protected]> Date: Sat, 14 Feb 2026 09:20:10 -0800 Subject: [PATCH] [lldb] Fix pid_t redefinition on Windows in ScriptInterpreterPythonInterfaces Move #include "lldb/Core/PluginManager.h" after the Python interface headers so that Python's pyconfig.h defines pid_t before PosixApi.h. This fixes the C2371 redefinition error on all Windows builders. --- .../Python/Interfaces/ScriptInterpreterPythonInterfaces.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptInterpreterPythonInterfaces.cpp b/lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptInterpreterPythonInterfaces.cpp index 96a81c9153736..c460b16ba8405 100644 --- a/lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptInterpreterPythonInterfaces.cpp +++ b/lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptInterpreterPythonInterfaces.cpp @@ -6,7 +6,6 @@ // //===----------------------------------------------------------------------===// -#include "lldb/Core/PluginManager.h" #include "lldb/Host/Config.h" #include "lldb/lldb-enumerations.h" @@ -14,6 +13,8 @@ #include "ScriptInterpreterPythonInterfaces.h" +#include "lldb/Core/PluginManager.h" + using namespace lldb; using namespace lldb_private; _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
