llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: None (rchamala) <details> <summary>Changes</summary> ## Summary - Move `#include "lldb/Core/PluginManager.h"` after `#include "ScriptInterpreterPythonInterfaces.h"` so Python's `pyconfig.h` defines `pid_t` before `PosixApi.h` gets included. This fixes the `C2371: 'pid_t': redefinition; different basic types` error on all Windows builders. Fixes CI failures from #<!-- -->181334 / #<!-- -->181488. ## Test plan - [ ] lldb-aarch64-windows build passes - [ ] lldb-x86_64-win build passes - [ ] lldb-remote-linux-win build passes --- Full diff: https://github.com/llvm/llvm-project/pull/181492.diff 1 Files Affected: - (modified) lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptInterpreterPythonInterfaces.cpp (+2-1) ``````````diff diff --git a/lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptInterpreterPythonInterfaces.cpp b/lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptInterpreterPythonInterfaces.cpp index 96a81c9153736..c460b16ba8405 100644 --- a/lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptInterpreterPythonInterfaces.cpp +++ b/lldb/source/Plugins/ScriptInterpreter/Python/Interfaces/ScriptInterpreterPythonInterfaces.cpp @@ -6,7 +6,6 @@ // //===----------------------------------------------------------------------===// -#include "lldb/Core/PluginManager.h" #include "lldb/Host/Config.h" #include "lldb/lldb-enumerations.h" @@ -14,6 +13,8 @@ #include "ScriptInterpreterPythonInterfaces.h" +#include "lldb/Core/PluginManager.h" + using namespace lldb; using namespace lldb_private; `````````` </details> https://github.com/llvm/llvm-project/pull/181492 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
