================
@@ -1465,6 +1465,101 @@ bool
DisassemblerLLVMC::MCDisasmInstance::IsAuthenticated(
return InstrDesc.isAuthenticated() || IsBrkC47x;
}
+static void
+UpdateSubtargetFeatures(const llvm::SubtargetFeatures &subtarget_features,
+ std::string &user_feature_overrides) {
+
+ // Extract the default features string from the SubtargetFeatures object.
+ // We must store this in a std::string variable to ensure the memory exists
+ // for the StringRef to point to during the execution of this function.
+ std::string default_features_storage = subtarget_features.getString();
+ llvm::StringRef default_features = default_features_storage;
----------------
JDevlieghere wrote:
This sounds like a very verbose way to say very little, which can easily be
inferred from the code.
```suggestion
std::string default_features_str = subtarget_features.str();
llvm::StringRef default_features = default_features_str;
```
https://github.com/llvm/llvm-project/pull/147990
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
