================
@@ -1465,6 +1465,101 @@ bool 
DisassemblerLLVMC::MCDisasmInstance::IsAuthenticated(
   return InstrDesc.isAuthenticated() || IsBrkC47x;
 }
 
+static void
+UpdateSubtargetFeatures(const llvm::SubtargetFeatures &subtarget_features,
+                        std::string &user_feature_overrides) {
----------------
JDevlieghere wrote:

Would it be more canonical to convert the user override as a 
`subtarget_features` and then merge them (possibly doing that in LLVM so it can 
be reused elsewhere?)

EDIT: seems like I misunderstood the signature. Why is this using an out 
parameter instead of returning a std::string?

https://github.com/llvm/llvm-project/pull/147990
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to