DavidSpickett wrote:

Github is being its usual stable, working, self, so here's the comment I was 
going to post on the diff:
Whats the effect of the `if(LLDB_ENABLE_... AND TARGET ...)?

I see that we should be only doing this if the targets exist, because we need 
to make dependencies. However, I'm not sure that we need both parts of the `if`.

Is there a situation where LLDB_ENABLE_... is off, but the targets get made 
anyway they're just not used?

Also this fixes a Windows issue but the fix seems quite generic. Has this also 
been an issue for Linux and we've not noticed it? 

https://github.com/llvm/llvm-project/pull/196070
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to