charles-zablit wrote:

> I don't think this is the right way to handle this. This tracks dependency 
> information on the side instead of making it a part of the existing 
> dependency-tracking and installation information in 
> `cmake/modules/AddLLDB.cmake`.

I agree. We now check inside `add_lldb_executable` if the tool links against 
liblldb. We have to do check if there is a transitive dependency because 
lldb-dap links against lldbDap which links against liblldb.

For Python and Lua, I'm not sure if there is a better way to do this, but now 
at least the logic lives in the `bindings/*/CMakeLists.txt` files.

https://github.com/llvm/llvm-project/pull/196070
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to