================
@@ -101,35 +101,67 @@ CreateRegisterInfoInterface(const ArchSpec &target_arch) {
target_arch, RegisterInfoPOSIX_arm64::eRegsetMaskDefault);
}
-static Status GetThreadContextHelper(lldb::thread_t thread_handle,
- PCONTEXT context_ptr,
- const DWORD control_flag) {
+static Status
+GetThreadContextHelper(lldb::thread_t thread_handle, DWORD context_flags,
+ PCONTEXT &context,
+ std::shared_ptr<DataBufferHeap> &context_buffer) {
----------------
DavidSpickett wrote:
In other words: passing a shared pointer by ref could suggest you deliberately
don't want to change the refcount.
Why would you not want to do that? No idea, but if I was reading this code for
the first time, I wouldn't have the context to know that it wasn't important.
https://github.com/llvm/llvm-project/pull/197385
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
