[Lldb-commits] [lldb] [lldb][Windows] Cache thread context in NativeRegisterContextWindows_arm64 (PR #197385)

[Ayush Sahay via lldb-commits]

================
@@ -267,11 +297,15 @@ Status NativeRegisterContextWindows_arm64::GPRRead(const 
uint32_t reg,
 Status
 NativeRegisterContextWindows_arm64::GPRWrite(const uint32_t reg,
                                              const RegisterValue &reg_value) {
-  ::CONTEXT tls_context;
-  DWORD context_flag = CONTEXT_CONTROL | CONTEXT_INTEGER;
+  auto cleanup = llvm::make_scope_exit([&]() { m_context = nullptr; });
----------------
ayushsahay1837 wrote:

That's the intention. We could have conservatively freed _m_context_buffer_ as 
well but like you mentioned, we don't anticipate the context length changing 
frequently, if at all. So, there might be value in just resizing and zeroing it 
out in _GetThreadContextHelper_ rather than resetting it.

https://github.com/llvm/llvm-project/pull/197385
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits