================
@@ -258,7 +268,17 @@
GDBRemoteCommunication::WaitForPacketNoLock(StringExtractorGDBRemote &packet,
error, bytes_read);
if (bytes_read > 0) {
- if (CheckForPacket(buffer, bytes_read, packet) != PacketType::Invalid)
+ // Drop any async notification packets (see above) and keep waiting for
+ // the actual response. Once the freshly-read bytes have been consumed,
+ // re-check the cache for any further buffered packets.
----------------
DavidSpickett wrote:
The second sentence doesn't add anything, you can remove it. I think the while
loop already implies we are checking again for new packets.
https://github.com/llvm/llvm-project/pull/202556
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits