dlgus8648 wrote:

Thanks @jasonmolenda, and no worries about the delay! I've added a comment on 
that `case eConnectionStatusSuccess:` (keeping the existing commented-out 
`printf`).

While writing it I traced where that zero-byte-success status actually comes 
from, so the comment notes it: `Read()` can return zero bytes with a success 
status on a non-socket connection when the underlying read returns `EAGAIN` 
(`ConnectionFileDescriptorPosix.cpp`); on a socket that same `EAGAIN` maps to 
`eConnectionStatusTimedOut` instead. Either way it's neither EOF nor an error, 
so we keep looping for the actual response — which, as you note, is exactly 
what we want after dropping one or more async notification packets. Pushed as a 
follow-up commit. Thanks again for the careful review!


https://github.com/llvm/llvm-project/pull/202556
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to