https://github.com/DavidSpickett approved this pull request.

Looks fine in isolation, but -

> My primary reason for doing this is so that I can refactor FileSpec's 
> interface to stop using ConstStrings.

For those unfamiliar with ConstString (aka me) it's not obvious why StringRef 
is a step towards removing ConstString. I presume it'll become clear in future 
PRs.

https://github.com/llvm/llvm-project/pull/204268
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to