jmfrank63 wrote:

I just received the welcome email, and wanted shortly to say thank you! While I 
have not done everything correctly as required, I got the main parts right :-) 

Let me amend what has been missing. 

I was not only in the loop I was in full control. The change does not cover 
llvm itself but the vscode extension. The extension is currently broken, so 
imho even slop has a hard time to beat this :-)

I used multiple agents, including github copilot, clause, codex, glm-5.2, qwen 
3.6 and Deepseek-v4-pro. 

Dozens of code reviews have been done. I am not taking this lightly and I am 
aware of the risk.

You will likely get Git Guardian high severity flags because I test against 
secret leakage and these test are flagged as leaked secrets. 

In general, the strategy is to detect python from PYTHONPATH and PATH if not 
found then use LLVM_PYTHON_LIBRARY and set the value for the extension during 
runtime to the other two environment vars.

No external environment is modified.

The final step has been a line by line manual review. I hope I have not 
overlooked anything.

https://github.com/llvm/llvm-project/pull/212989
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to