charles-zablit wrote: Thanks for the clarifications, I think I understand what this PR does now. My understanding is: On version of LLVM greater than 23, we have the `--check-python` command which correctly checks if Python is available for lldb to use. That flow works correctly in lldb-dap. However, in previous version of LLVM, this command did not exist and the extension fails to start even if Python is correctly installed, which is a bug. You are trying to fix this by relying on Python env variables and the `--print-script-interpreter-info` command.
I think the approach to rely on `--print-script-interpreter-info` as a fallback to `--check-python` is interesting and worth exploring. It can be useful for previous versions of LLVM. However, I'm not convinced about the env variable check. If Python is not in the PATH, lldb will not find it (unless python310.dll is right next to the lldb-dap binary). The only information we can gather from finding Python env variables on the system is: "python seems to be installed but it's not in your PATH". While useful, I think this adds a lot of complexity to the extension for a small feature gain, from the users' perspective. We can always reconsider this later, but I think that for the time being, it's best to focus on the `--print-script-interpreter-info` fallback. https://github.com/llvm/llvm-project/pull/212989 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
