https://github.com/lhames created https://github.com/llvm/llvm-project/pull/213196
The default destructor will already reset members in the correct order. >From 970865a24b9e03b1997f50bd1abdfcf5b88aa712 Mon Sep 17 00:00:00 2001 From: Lang Hames <[email protected]> Date: Fri, 31 Jul 2026 14:19:07 +1000 Subject: [PATCH] [lldb] Remove redundant IRExecutionUnit destructor. The default destructor will already reset members in the correct order. --- lldb/include/lldb/Expression/IRExecutionUnit.h | 3 --- lldb/source/Expression/IRExecutionUnit.cpp | 6 ------ 2 files changed, 9 deletions(-) diff --git a/lldb/include/lldb/Expression/IRExecutionUnit.h b/lldb/include/lldb/Expression/IRExecutionUnit.h index 10bd1a0f46cf0..d1fe6fc042039 100644 --- a/lldb/include/lldb/Expression/IRExecutionUnit.h +++ b/lldb/include/lldb/Expression/IRExecutionUnit.h @@ -64,9 +64,6 @@ class IRExecutionUnit : public std::enable_shared_from_this<IRExecutionUnit>, const lldb::TargetSP &target_sp, const SymbolContext &sym_ctx, std::vector<std::string> &cpu_features); - /// Destructor - ~IRExecutionUnit() override; - ConstString GetFunctionName() { return m_name; } llvm::Module *GetModule() { return m_module; } diff --git a/lldb/source/Expression/IRExecutionUnit.cpp b/lldb/source/Expression/IRExecutionUnit.cpp index 49edc2cdc5462..d7799cc40122b 100644 --- a/lldb/source/Expression/IRExecutionUnit.cpp +++ b/lldb/source/Expression/IRExecutionUnit.cpp @@ -503,12 +503,6 @@ void IRExecutionUnit::GetRunnableInfo(Status &error, lldb::addr_t &func_addr, func_end = m_function_end_load_addr; } -IRExecutionUnit::~IRExecutionUnit() { - m_module_up.reset(); - m_execution_engine_up.reset(); - m_context_up.reset(); -} - IRExecutionUnit::MemoryManager::MemoryManager(IRExecutionUnit &parent) : m_default_mm_up(new llvm::SectionMemoryManager()), m_parent(parent) {} _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
