llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Lang Hames (lhames) <details> <summary>Changes</summary> The default destructor will already reset members in the correct order. --- Full diff: https://github.com/llvm/llvm-project/pull/213196.diff 2 Files Affected: - (modified) lldb/include/lldb/Expression/IRExecutionUnit.h (-3) - (modified) lldb/source/Expression/IRExecutionUnit.cpp (-6) ``````````diff diff --git a/lldb/include/lldb/Expression/IRExecutionUnit.h b/lldb/include/lldb/Expression/IRExecutionUnit.h index 10bd1a0f46cf0..d1fe6fc042039 100644 --- a/lldb/include/lldb/Expression/IRExecutionUnit.h +++ b/lldb/include/lldb/Expression/IRExecutionUnit.h @@ -64,9 +64,6 @@ class IRExecutionUnit : public std::enable_shared_from_this<IRExecutionUnit>, const lldb::TargetSP &target_sp, const SymbolContext &sym_ctx, std::vector<std::string> &cpu_features); - /// Destructor - ~IRExecutionUnit() override; - ConstString GetFunctionName() { return m_name; } llvm::Module *GetModule() { return m_module; } diff --git a/lldb/source/Expression/IRExecutionUnit.cpp b/lldb/source/Expression/IRExecutionUnit.cpp index 49edc2cdc5462..d7799cc40122b 100644 --- a/lldb/source/Expression/IRExecutionUnit.cpp +++ b/lldb/source/Expression/IRExecutionUnit.cpp @@ -503,12 +503,6 @@ void IRExecutionUnit::GetRunnableInfo(Status &error, lldb::addr_t &func_addr, func_end = m_function_end_load_addr; } -IRExecutionUnit::~IRExecutionUnit() { - m_module_up.reset(); - m_execution_engine_up.reset(); - m_context_up.reset(); -} - IRExecutionUnit::MemoryManager::MemoryManager(IRExecutionUnit &parent) : m_default_mm_up(new llvm::SectionMemoryManager()), m_parent(parent) {} `````````` </details> https://github.com/llvm/llvm-project/pull/213196 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
