JDevlieghere wrote: I've updated the approach based on the feedback here. Here's what changed:
- Instead of a new packet, `qWasmGlobal` now takes the instance as a `;address_space:<id>;` key-value suffix in place of the frame index when supported. This matches what's proposed in #206370 and doesn't require us to do something different when we adopt address spaces for Wasm (which will be necessary for 64-bit Wasm). - Per @paolosevMSFT's suggestion, `qWasmInstance+`, which covers every Wasm packet whose scope is an instance rather than a frame. - Per @kateinoigakukun's suggestion, the documentation now spell out the address layout and that a reported load address is the module base in the object space for the current "implicit address space" approach. https://github.com/llvm/llvm-project/pull/213176 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
