JDevlieghere wrote: Thanks everyone. Updated based on the feedback here:
- Back to `instance:` instead of `address_space:`. We'll need to make changes for address spaces in the gdb-remote protocol anyway, so let's get it right then instead of trying to predict what that will look like and possibly putting ourselves in a corner. - Allow zero as a valid instance id. @paolosevMSFT confirmed V8 numbers from zero and @jasonmolenda was right that the old "reserved for the default address space" claim double-booked the tag bits. The sentinel is now `UINT32_MAX`, outside the 30-bit id range, with a `static_assert`. - One `qSupported` feature. Per @paolosevMSFT, `qWasmInstance+` covers every Wasm packet whose scope is an instance rather than a frame, so `qWasmMem` and friends carry the same suffix. - Trimmed the feature section, added the `qSupported` exchange example, and moved the 64-bit address layout up into the `Wasm Packets` intro since it covers every Wams packet. @jasonmolenda on your two open questions: `memory64` is standardized, so 64-bit linear addresses are real. I think most major runtimes support them, but 32-bit is still very much the standard. https://github.com/llvm/llvm-project/pull/213176 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
