================
@@ -5040,7 +5040,7 @@ static void ParseEnums(
             LLDB_LOG(log,
                      "ProcessGDBRemote::ParseEnums Found enum type \"{0}\"",
                      id);
-            registers_enum_types.insert_or_assign(
----------------
DavidSpickett wrote:

https://sourceware.org/gdb/current/onlinedocs/gdb.html/Target-Description-Format.html

"Each type element must have an ‘id’ attribute, which gives a unique (within 
the containing ‘<feature>’) name to the type. Types must be defined before they 
are used."

So you are right we are not following this rule correctly.

Let's address this in a follow up PR along with the fact that id lookup (and 
collisions) should not care what element type has the ID.

https://github.com/llvm/llvm-project/pull/213887
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to