================
@@ -5040,7 +5040,7 @@ static void ParseEnums(
LLDB_LOG(log,
"ProcessGDBRemote::ParseEnums Found enum type \"{0}\"",
id);
- registers_enum_types.insert_or_assign(
----------------
DavidSpickett wrote:
> A GDB remote server should be returning valid data.
I think our definition of valid is incorrect, but we can fix it. And you're
right that most servers aren't going to get adventurous.
> Maybe we just want to emit an error to the debugger's output stream (and to a
> log) so the user can see when there are issues? So see a type, check if there
> is already a type and emit an error message with the XML output and just
> ignore any new types that have already been defined using that name?
Currently we log them.
We could print them in the interface, or we could have a general "there were
problems, check the log". I'll deal with that in a follow up if that's ok. The
errors and logging are scattered throughout the GDB client code at the moment,
so it's hard to gather it into one coherent report. So I should address that
along the way.
https://github.com/llvm/llvm-project/pull/213887
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
