https://github.com/firmiana402 requested changes to this pull request.
DWARF v5 specifies that the ULEB128 operand of DW_OP_plus_uconst is interpreted as the same type as the value popped from the stack. Therefore, `uconst_value` should first be converted to the exact type of `stack.back().GetScalar()` (including bit width and signedness). Performing the addition as uint64_t and truncating afterward is not equivalent, because type promotion has already changed the signedness and GetByteSize() * 8 cannot recover non-byte-aligned widths. Could we instead construct the addend with the stack operand’s type before performing the addition? https://github.com/llvm/llvm-project/pull/204896 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
