jimingham wrote: This looks like a faithful translation into a single entry point. In the previous patch where you added a BinarySpec, you made a class that stored both the request and the response and passed that around. Then in this somewhat analogous situation, you made separate Request and Result objects. Nothing wrong with that, but I wondered why you made different choices in the two situations?
https://github.com/llvm/llvm-project/pull/215391 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
