JDevlieghere wrote: > Then in this somewhat analogous situation, you made separate Request and > Result objects. Nothing wrong with that, but I wondered why you made > different choices in the two situations?
I actually started out with the single object exactly like BinarySpec as an in-out object. I didn't like how it had to encode the Error/Status from the symbol server and then also have the `module_sp` convey whether something was found or not and either having to have another Error/Status to explain why, or having to repurpose the other one for it. Plus the locator function was returning a void so an Expected<Result> seemed like an obvious solution. For the BinarySpec I mimicked ModuleSpec which is also used as an in-out. I don't mind revisiting that if we think it should be more consistent with what I'm doing here. https://github.com/llvm/llvm-project/pull/215391 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
