[Lldb-commits] [lldb] [lldb] Cache register types by object UID and register size (PR #215874)

[David Spickett via lldb-commits]

================
@@ -33,15 +33,33 @@ class RegisterTypeBuilderClang : public RegisterTypeBuilder 
{
   CompilerType GetRegisterType(const RegisterInfo &reg_info) override;
----------------
DavidSpickett wrote:

We don't want callers to cache this CompilerType themselves, right? We need 
them to ask the builder each time, in case the type system has changed.

We should document that in a comment here.

It's what all the existing callers do anyway but I never thought that clearly 
about it.

https://github.com/llvm/llvm-project/pull/215874
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits