DavidSpickett wrote:

> This also prevents a new process from aliasing stale entries when an 
> allocator reuses a RegisterType address.

There is a future use case that could do this and it's to do with handling 
https://lldb.llvm.org/resources/addingtargetsupport.html#registers-that-come-and-go-at-runtime.

At the moment a ProcessGDBRemote is only going to parse the target XML once. If 
in future we allow it to get it again (because a feature has been turned on/off 
in the debugee), then it would free all the RegisterType it had made and the 
new ones could reuse addresses.

So we aren't doing it now and I'd try to avoid needing it but it does add to 
the case that a unique ID is simpler to reason about overall.

https://github.com/llvm/llvm-project/pull/215874
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to