https://github.com/Teemperor approved this pull request.
To be honest, the whole stacked PR thing is not very well implemented in GitHub, and if I review the wrong part of the PR then I blame that. Oh, Phabricator my beloved, why hast thou forsaken us... Anyway, this LGTM, but this function could benefit from a `assert(llvm::has_single_bit(static_cast<uint32_t>(set)) && "GetPtraceSet expects a single set")`, but otherwise this LGTM. https://github.com/llvm/llvm-project/pull/213975 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
