Author: David Spickett Date: 2026-08-17T13:13:17Z New Revision: 89ad6f51f475cd6fe190cdeb51fc20f86c151fbc
URL: https://github.com/llvm/llvm-project/commit/89ad6f51f475cd6fe190cdeb51fc20f86c151fbc DIFF: https://github.com/llvm/llvm-project/commit/89ad6f51f475cd6fe190cdeb51fc20f86c151fbc.diff LOG: [lldb][test] Fix skip in TestWriteMemoryWithHWBreakpoint.py (#216723) In a87b27fd5161ec43527fc3356852046a321ea82c, the opposite skip was put in. It should skip if hardware breakpoints are *not* supported. Also that commit added a stray "skip". I have removed that and fixed the incorrect variable name. Added: Modified: lldb/test/API/functionalities/breakpoint/hardware_breakpoints/write_memory_with_hw_breakpoint/TestWriteMemoryWithHWBreakpoint.py Removed: ################################################################################ diff --git a/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/write_memory_with_hw_breakpoint/TestWriteMemoryWithHWBreakpoint.py b/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/write_memory_with_hw_breakpoint/TestWriteMemoryWithHWBreakpoint.py index c82ae24a6d9ab..c7c4c09454ef0 100644 --- a/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/write_memory_with_hw_breakpoint/TestWriteMemoryWithHWBreakpoint.py +++ b/lldb/test/API/functionalities/breakpoint/hardware_breakpoints/write_memory_with_hw_breakpoint/TestWriteMemoryWithHWBreakpoint.py @@ -13,8 +13,7 @@ class WriteMemoryWithHWBreakpoint(HardwareBreakpointTestBase): - @skipTestIfFn(HardwareBreakpointTestBase.supports_hw_breakpoints) - @skip + @skipTestIfFn(HardwareBreakpointTestBase.hw_breakpoints_unsupported) def test_copy_memory_with_hw_break(self): self.build() exe = self.getBuildArtifact("a.out") @@ -46,4 +45,4 @@ def test_copy_memory_with_hw_break(self): error = lldb.SBError() result = process.WriteMemory(address, data, error) - self.assertTrue(error.Success() and result == len(bytes)) + self.assertTrue(error.Success() and result == len(data)) _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
