================
@@ -584,9 +586,13 @@ ThreadSP AppleObjCRuntime::GetBacktraceThreadFromException(
size_t ptr_size = m_process->GetAddressByteSize();
std::vector<lldb::addr_t> pcs;
for (size_t idx = 0; idx < count; idx++) {
- Status error;
- addr_t pc = m_process->ReadPointerFromMemory(
- frames_addr + (ignore + idx) * ptr_size, error);
+ addr_t pc = LLDB_INVALID_ADDRESS;
+ if (llvm::Expected<lldb::addr_t> pc_or_err =
+ m_process->ReadPointerFromMemory(frames_addr +
+ (ignore + idx) * ptr_size))
+ pc = *pc_or_err;
+ else
+ llvm::consumeError(pc_or_err.takeError());
----------------
felipepiovezan wrote:
If the scopes were much bigger, maybe (tbh, I wouldn't) it can be argued that
suffixes are a good thing.
But they are not enforceable by the compiler, and will rot during the course of
code updates.
https://github.com/llvm/llvm-project/pull/216389
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
